Skip to content

chore: add snapshot testing via md files #1054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 55 commits into from
Feb 3, 2024
Merged

chore: add snapshot testing via md files #1054

merged 55 commits into from
Feb 3, 2024

Conversation

mogery
Copy link
Contributor

@mogery mogery commented Jan 27, 2024 •
edited
Loading

Summary:
This PR adds tests/execution_spec.rs, which uses snapshots via insta and .md specs to perform testing, like outlined in #983. It also adds testconv, an automatic test converter.

To-do:

  • Convert from http_spec
  • Convert from graphql_spec

Issue Reference(s):
Fixes #983
/claim #983

Build & Testing:

  • I ran cargo test successfully.
  • I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

Checklist:

  • I have added relevant unit & integration tests.
  • I have updated the documentation accordingly.
  • I have performed a self-review of my code.
  • PR follows the naming convention of <type>(<optional scope>): <title>

@algora-pbc algora-pbc bot mentioned this pull request Jan 27, 2024
Closed
@github-actions github-actions bot added the type: feature Brand new functionality, features, pages, workflows, endpoints, etc. label Jan 27, 2024
@mogery mogery mentioned this pull request Jan 29, 2024
Merged
6 tasks
mogery added 16 commits January 30, 2024 07:48
@mogery
feat(tests/execution_spec): add http support
8062aa5
@mogery
feat(tests/execution_spec): add snapshot testing
33547ce
@mogery
feat(testconv): poc for converting http tests
1fb4e15
@mogery
feat(testconv): compatibility fixes
444d024
@mogery
feat(testconv): convert http_spec
4c13b17
@mogery
chore: lint
0fd552c
@mogery
fix(execution_spec): catch up to API changes
8d26197
@mogery
fix(testconv): order headers correctly for the snapshots
1975923
@mogery
feat(execution_spec): annotation support (without fail)
4e3b4b7
@mogery
feat(testconv): support annotations, and deal with fail
77d592c
@mogery
feat(execution_spec): allow running only one test explicitly
55edaad
@mogery
feat(testconv): automatically convert fail annotated tests
304a7b0
@mogery
feat(testconv): handle autoconversion of bad graphql
bccb5fa
@mogery
feat(testconv): auto-run prettier on generated markdown
c8857f7
@mogery
feat(execution_spec): add server config identity and round-trip checks
45ab945
@mogery
feat(testconv): skip tests that use @cache until tailcallhq#1058 is m…
14b6694 
…erged
@mogery mogery force-pushed the mog/execution-spec branch from 34a041b to 14b6694 Compare January 30, 2024 07:49
@codecov Codecov
Copy link

codecov bot commented Jan 30, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f3cf2f1) 88.26% compared to head (9976d54) 88.38%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1054      +/-   ##
==========================================
+ Coverage   88.26%   88.38%   +0.11%     
==========================================
  Files         102      102              
  Lines       10994    10994              
==========================================
+ Hits         9704     9717      +13     
+ Misses       1290     1277      -13

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mogery
Copy link
Contributor Author

mogery commented Jan 31, 2024

This is now ready. I've also written some docs.

@tusharmath tusharmath enabled auto-merge (squash) February 3, 2024 08:58
@tusharmath tusharmath changed the title feat: add execution_spec for snapshot testing via md files chore: add execution_spec for snapshot testing via md files Feb 3, 2024
@tusharmath tusharmath added type: chore Routine tasks like conversions, reorganization, and maintenance work. and removed type: feature Brand new functionality, features, pages, workflows, endpoints, etc. labels Feb 3, 2024
@github-actions github-actions bot added the type: feature Brand new functionality, features, pages, workflows, endpoints, etc. label Feb 3, 2024
@tusharmath tusharmath changed the title chore: add execution_spec for snapshot testing via md files chore: add snapshot testing via md files Feb 3, 2024
auto-merge was automatically disabled February 3, 2024 10:35

Head branch was pushed to by a user without write access

@tusharmath tusharmath merged commit b7843b2 into tailcallhq:main Feb 3, 2024
@tusharmath
Copy link
Contributor

/tip 50$

@algora-pbc Algora PBC
Copy link

algora-pbc bot commented Feb 3, 2024

🎉🎈 @mogery has been awarded $50! 🎈🎊

@mogery mogery deleted the mog/execution-spec branch February 3, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tusharmath tusharmath tusharmath approved these changes

Assignees
No one assigned
Labels
🙋 Bounty claim 💰 Rewarded type: chore Routine tasks like conversions, reorganization, and maintenance work. type: feature Brand new functionality, features, pages, workflows, endpoints, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Perform snapshot testing using md files
2 participants
@mogery @tusharmath